Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e4d26b02 authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

scripts/get_maintainer.pl: optionally ignore non-maintainer signatures 



When using --git to determine who to send a patch to, get_maintainers will
currently include all signatures.  This can include signers that simply
report an issue or test a patch.  Signers that use this tag are not
necessarily good candidates to review new patches.

This patch allows get_maintainers to optionally restrict output to only
signatures that use Signed-off-by:, Acked-by:, or Reviewed-by:.

Signed-off-by: is included because those are people who are responsible
for the code.

Acked-by: is questionable, but as signers that use this tag tend to be
active linux gatekeepers, false positives are tolerable.

Reviewed-by: is included because signers responsible for the code thought
that the review feedback for a changeset by that signer was valuable.

This patch has been modified from Florian's original submission to change
the supported signature types to the canonical forms and use slightly
different spacing.  A couple of spacing issues were also corrected in the
original source.  The command line argument was also renamed.

Original-patch-by: default avatarFlorian Mickler <florian@mickler.org>
Signed-off-by: default avatarFlorian Mickler <florian@mickler.org>
Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent cf3b429b

scripts/get_maintainer.pl

+26 −9
Original line number Original line Diff line number Diff line
@@ -25,6 +25,7 @@ my $email_list = 1; 
my $email_subscriber_list = 0;

my $email_subscriber_list = 0;

my $email_git_penguin_chiefs = 0;

my $email_git_penguin_chiefs = 0;

my $email_git = 1;

my $email_git = 1;

my $email_git_all_signature_types = 1;

my $email_git_blame = 0;

my $email_git_blame = 0;

my $email_git_min_signatures = 1;

my $email_git_min_signatures = 1;

my $email_git_max_maintainers = 5;

my $email_git_max_maintainers = 5;
@@ -65,6 +66,15 @@ foreach my $chief (@penguin_chief) { 
}

}

my $penguin_chiefs = "\(" . join("|", @penguin_chief_names) . "\)";

my $penguin_chiefs = "\(" . join("|", @penguin_chief_names) . "\)";





# Signature types of people who are either

# 	a) responsible for the code in question, or

# 	b) familiar enough with it to give relevant feedback

my @signature_tags = ();

push(@signature_tags, "Signed-off-by:");

push(@signature_tags, "Reviewed-by:");

push(@signature_tags, "Acked-by:");

my $signaturePattern = "\(" . join("|", @signature_tags) . "\)";



# rfc822 email address - preloaded methods go here.

# rfc822 email address - preloaded methods go here.

my $rfc822_lwsp = "(?:(?:\\r\\n)?[ \\t])";

my $rfc822_lwsp = "(?:(?:\\r\\n)?[ \\t])";

my $rfc822_char = '[\\000-\\377]';

my $rfc822_char = '[\\000-\\377]';
@@ -100,6 +110,7 @@ my %VCS_cmds_hg = ( 
if (!GetOptions(

if (!GetOptions(

		'email!' => \$email,

		'email!' => \$email,

		'git!' => \$email_git,

		'git!' => \$email_git,

		'git-all-signature-types!' => \$email_git_all_signature_types,

		'git-blame!' => \$email_git_blame,

		'git-blame!' => \$email_git_blame,

		'git-chief-penguins!' => \$email_git_penguin_chiefs,

		'git-chief-penguins!' => \$email_git_penguin_chiefs,

		'git-min-signatures=i' => \$email_git_min_signatures,

		'git-min-signatures=i' => \$email_git_min_signatures,
@@ -180,6 +191,10 @@ if (!top_of_kernel_tree($lk_path)) { 
	. "a linux kernel source tree.\n";

	. "a linux kernel source tree.\n";

}

}





if ($email_git_all_signature_types) {

    $signaturePattern = "(.+?)[Bb][Yy]:";

}



## Read MAINTAINERS for type/value pairs

## Read MAINTAINERS for type/value pairs





my @typevalue = ();

my @typevalue = ();
@@ -497,13 +512,15 @@ version: $V 
MAINTAINER field selection options:

MAINTAINER field selection options:

  --email => print email address(es) if any

  --email => print email address(es) if any

    --git => include recent git \*-by: signers

    --git => include recent git \*-by: signers

    --git-all-signature-types => include signers regardless of signature type

        or use only ${signaturePattern} signers (default: $email_git_all_signature_types)

    --git-chief-penguins => include ${penguin_chiefs}

    --git-chief-penguins => include ${penguin_chiefs}

    --git-min-signatures => number of signatures required (default: 1)

    --git-min-signatures => number of signatures required (default: $email_git_min_signatures)

    --git-max-maintainers => maximum maintainers to add (default: 5)

    --git-max-maintainers => maximum maintainers to add (default: $email_git_max_maintainers)

    --git-min-percent => minimum percentage of commits required (default: 5)

    --git-min-percent => minimum percentage of commits required (default: $email_git_min_percent)

    --git-blame => use git blame to find modified commits for patch or file

    --git-blame => use git blame to find modified commits for patch or file

    --git-since => git history to use (default: 1-year-ago)

    --git-since => git history to use (default: $email_git_since)

    --hg-since => hg history to use (default: -365)

    --hg-since => hg history to use (default: $email_hg_since)

    --m => include maintainer(s) if any

    --m => include maintainer(s) if any

    --n => include name 'Full Name <addr\@domain.tld>'

    --n => include name 'Full Name <addr\@domain.tld>'

    --l => include list(s) if any

    --l => include list(s) if any
@@ -964,7 +981,7 @@ sub vcs_find_signers { 




    $commits = grep(/$pattern/, @lines);	# of commits

    $commits = grep(/$pattern/, @lines);	# of commits





    @lines = grep(/^[-_ 	a-z]+by:.*\@.*$/i, @lines);

    @lines = grep(/^[ \t]*${signaturePattern}.*\@.*$/, @lines);

    if (!$email_git_penguin_chiefs) {

    if (!$email_git_penguin_chiefs) {

	@lines = grep(!/${penguin_chiefs}/i, @lines);

	@lines = grep(!/${penguin_chiefs}/i, @lines);

    }

    }