Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e30d8f23 authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Mark Brown
Browse files

spi: bitbang: remove unneeded check 



Remove an unneeded check. The SPI core (__spi_validate) takes care
that these fields are always populated.

Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent c15f6ed3

drivers/spi/spi-bitbang.c

+4 −14
Original line number Diff line number Diff line
@@ -272,7 +272,6 @@ static int spi_bitbang_transfer_one(struct spi_master *master, 
	struct spi_transfer	*t = NULL;

	unsigned		cs_change;

	int			status;

	int			do_setup = -1;

	struct spi_device	*spi = m->spi;



	bitbang = spi_master_get_devdata(master);
@@ -288,20 +287,11 @@ static int spi_bitbang_transfer_one(struct spi_master *master, 


	list_for_each_entry(t, &m->transfers, transfer_list) {



		/* override speed or wordsize? */

		if (t->speed_hz || t->bits_per_word)

			do_setup = 1;



		/* init (-1) or override (1) transfer params */

		if (do_setup != 0) {

		if (bitbang->setup_transfer) {

			status = bitbang->setup_transfer(spi, t);

			if (status < 0)

				break;

		}

			if (do_setup == -1)

				do_setup = 0;

		}



		/* set up default clock polarity, and activate chip;

		 * this implicitly updates clock and spi modes as