Commit e24e2e64 authored Mar 10, 2008 by Alexey Dobriyan Committed by Linus Torvalds Mar 10, 2008

modules: warn about suspicious return values from module's ->init() hook



Return value convention of module's init functions is 0/-E.  Sometimes,
e.g.  during forward-porting mistakes happen and buggy module created,
where result of comparison "workqueue != NULL" is propagated all the way up
to sys_init_module.  What happens is that some other module created
workqueue in question, our module created it again and module was
successfully loaded.

Or it could be some other bug.

Let's make such mistakes much more visible.  In retrospective, such
messages would noticeably shorten some of my head-scratching sessions.

Note, that dump_stack() is just a way to get attention from user.  Sample
message:

sys_init_module: 'foo'->init suspiciously returned 1, it should follow 0/-E convention
sys_init_module: loading module anyway...
Pid: 4223, comm: modprobe Not tainted 2.6.24-25f66630 #5

Call Trace:
 [<ffffffff80254b05>] sys_init_module+0xe5/0x1d0
 [<ffffffff8020b39b>] system_call_after_swapgs+0x7b/0x80

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 6c5db22d

kernel/module.c

+8 −0

Original line number	Original line	Diff line number	Diff line
	@@ -2178,6 +2178,14 @@ sys_init_module(void __user *umod,
	wake_up(&module_wq);		wake_up(&module_wq);
	return ret;		return ret;
	}		}
			if (ret > 0) {
			printk(KERN_WARNING "%s: '%s'->init suspiciously returned %d, "
			"it should follow 0/-E convention\n"
			KERN_WARNING "%s: loading module anyway...\n",
			__func__, mod->name, ret,
			__func__);
			dump_stack();
			}

	/* Now it's a first class citizen! Wake up anyone waiting for it. */		/* Now it's a first class citizen! Wake up anyone waiting for it. */
	mod->state = MODULE_STATE_LIVE;		mod->state = MODULE_STATE_LIVE;