Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e247bd90 authored by Johannes Berg's avatar Johannes Berg Committed by John W. Linville
Browse files

cfg80211/mac80211: allow management TX to not wait for ACK 



For probe responses it can be useful to not wait for ACK to
avoid retransmissions if the station that sent the probe is
already on the next channel, so allow userspace to request
not caring about the ACK with a new nl80211 flag.

Since mac80211 needs to be updated for the new function
prototype anyway implement it right away -- it's just a
few lines of code.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent e7f4a940

drivers/net/wireless/ath/ath6kl/cfg80211.c

+2 −1
Original line number Diff line number Diff line
@@ -1732,7 +1732,8 @@ static int ath6kl_mgmt_tx(struct wiphy *wiphy, struct net_device *dev, 
			  struct ieee80211_channel *chan, bool offchan,

			  enum nl80211_channel_type channel_type,

			  bool channel_type_valid, unsigned int wait,

			  const u8 *buf, size_t len, bool no_cck, u64 *cookie)

			  const u8 *buf, size_t len, bool no_cck,

			  bool dont_wait_for_ack, u64 *cookie)

{

	struct ath6kl *ar = ath6kl_priv(dev);

	u32 id;

include/linux/nl80211.h

+7 −0
Original line number Diff line number Diff line
@@ -1151,6 +1151,11 @@ enum nl80211_commands { 
 *	with support for the features listed in this attribute, see

 *	&enum nl80211_ap_sme_features.

 *

 * @NL80211_ATTR_DONT_WAIT_FOR_ACK: Used with %NL80211_CMD_FRAME, this tells

 *	the driver to not wait for an acknowledgement. Note that due to this,

 *	it will also not give a status callback nor return a cookie. This is

 *	mostly useful for probe responses to save airtime.

 *

 * @NL80211_ATTR_MAX: highest attribute number currently defined

 * @__NL80211_ATTR_AFTER_LAST: internal use

 */
@@ -1381,6 +1386,8 @@ enum nl80211_attrs { 


	NL80211_ATTR_DEVICE_AP_SME,



	NL80211_ATTR_DONT_WAIT_FOR_ACK,



	/* add attributes here, update the policy in nl80211.c */



	__NL80211_ATTR_AFTER_LAST,

include/net/cfg80211.h

+1 −1
Original line number Diff line number Diff line
@@ -1588,7 +1588,7 @@ struct cfg80211_ops { 
			  enum nl80211_channel_type channel_type,

			  bool channel_type_valid, unsigned int wait,

			  const u8 *buf, size_t len, bool no_cck,

			  u64 *cookie);

			  bool dont_wait_for_ack, u64 *cookie);

	int	(*mgmt_tx_cancel_wait)(struct wiphy *wiphy,

				       struct net_device *dev,

				       u64 cookie);

net/mac80211/cfg.c

+8 −3
Original line number Diff line number Diff line
@@ -1936,7 +1936,7 @@ static int ieee80211_mgmt_tx(struct wiphy *wiphy, struct net_device *dev, 
			     enum nl80211_channel_type channel_type,

			     bool channel_type_valid, unsigned int wait,

			     const u8 *buf, size_t len, bool no_cck,

			     u64 *cookie)

			     bool dont_wait_for_ack, u64 *cookie)

{

	struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev);

	struct ieee80211_local *local = sdata->local;
@@ -1944,10 +1944,15 @@ static int ieee80211_mgmt_tx(struct wiphy *wiphy, struct net_device *dev, 
	struct sta_info *sta;

	struct ieee80211_work *wk;

	const struct ieee80211_mgmt *mgmt = (void *)buf;

	u32 flags = IEEE80211_TX_INTFL_NL80211_FRAME_TX |

		    IEEE80211_TX_CTL_REQ_TX_STATUS;

	u32 flags;

	bool is_offchan = false;



	if (dont_wait_for_ack)

		flags = IEEE80211_TX_CTL_NO_ACK;

	else

		flags = IEEE80211_TX_INTFL_NL80211_FRAME_TX |

			IEEE80211_TX_CTL_REQ_TX_STATUS;



	/* Check that we are on the requested channel for transmission */

	if (chan != local->tmp_channel &&

	    chan != local->oper_channel)

net/wireless/core.h

+1 −1
Original line number Diff line number Diff line
@@ -378,7 +378,7 @@ int cfg80211_mlme_mgmt_tx(struct cfg80211_registered_device *rdev, 
			  enum nl80211_channel_type channel_type,

			  bool channel_type_valid, unsigned int wait,

			  const u8 *buf, size_t len, bool no_cck,

			  u64 *cookie);

			  bool dont_wait_for_ack, u64 *cookie);



/* SME */

int __cfg80211_connect(struct cfg80211_registered_device *rdev,