Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e1a7d248 authored by Martin Sperl's avatar Martin Sperl Committed by Greg Kroah-Hartman
Browse files

serial: bcm2835: fix unsigned int issue with irq 



Fixes error condition check when requesting the irq,
that would not trigger because of uart_port.irq being
defined as unsigned int.

Reported by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMartin Sperl <kernel@martin.sperl.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0ab556c2

drivers/tty/serial/8250/8250_bcm2835aux.c

+5 −5
Original line number Diff line number Diff line
@@ -59,12 +59,12 @@ static int bcm2835aux_serial_probe(struct platform_device *pdev) 
	}



	/* get the interrupt */

	data->uart.port.irq = platform_get_irq(pdev, 0);

	if (data->uart.port.irq < 0) {

		dev_err(&pdev->dev, "irq not found - %i",

			data->uart.port.irq);

		return data->uart.port.irq;

	ret = platform_get_irq(pdev, 0);

	if (ret < 0) {

		dev_err(&pdev->dev, "irq not found - %i", ret);

		return ret;

	}

	data->uart.port.irq = ret;



	/* map the main registers */

	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);