Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e1615903 authored by Yuval Mintz's avatar Yuval Mintz Committed by David S. Miller
Browse files

bnx2x: Prevent null pointer dereference on SKB release 



On error flows its possible to free an SKB even if it was not allocated.

Signed-off-by: default avatarYuval Mintz <Yuval.Mintz@qlogic.com>
Signed-off-by: default avatarAriel Elior <Ariel.Elior@qlogic.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 21a44763

drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c

+1 −1
Original line number Diff line number Diff line
@@ -262,9 +262,9 @@ static u16 bnx2x_free_tx_pkt(struct bnx2x *bp, struct bnx2x_fp_txdata *txdata, 
	if (likely(skb)) {

		(*pkts_compl)++;

		(*bytes_compl) += skb->len;

		dev_kfree_skb_any(skb);

	}



	dev_kfree_skb_any(skb);

	tx_buf->first_bd = 0;

	tx_buf->skb = NULL;