Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dff232da authored by Dave Jiang's avatar Dave Jiang Committed by Vinod Koul
Browse files

dmaengine: at_hdmac: convert callback to helper function 



This is in preperation of moving to a callback that provides results to the
callback for the transaction. The conversion will maintain current behavior
and the driver must convert to new callback mechanism at a later time in
order to receive results.

Signed-off-by: default avatarDave Jiang <dave.jiang@intel.com>
Reviewed-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent f083f557

drivers/dma/at_hdmac.c

+2 −9
Original line number Diff line number Diff line
@@ -473,15 +473,11 @@ atc_chain_complete(struct at_dma_chan *atchan, struct at_desc *desc) 
	/* for cyclic transfers,

	 * no need to replay callback function while stopping */

	if (!atc_chan_is_cyclic(atchan)) {

		dma_async_tx_callback	callback = txd->callback;

		void			*param = txd->callback_param;



		/*

		 * The API requires that no submissions are done from a

		 * callback, so we don't need to drop the lock here

		 */

		if (callback)

			callback(param);

		dmaengine_desc_get_callback_invoke(txd, NULL);

	}



	dma_run_dependencies(txd);
@@ -598,15 +594,12 @@ static void atc_handle_cyclic(struct at_dma_chan *atchan) 
{

	struct at_desc			*first = atc_first_active(atchan);

	struct dma_async_tx_descriptor	*txd = &first->txd;

	dma_async_tx_callback		callback = txd->callback;

	void				*param = txd->callback_param;



	dev_vdbg(chan2dev(&atchan->chan_common),

			"new cyclic period llp 0x%08x\n",

			channel_readl(atchan, DSCR));



	if (callback)

		callback(param);

	dmaengine_desc_get_callback_invoke(txd, NULL);

}



/*--  IRQ & Tasklet  ---------------------------------------------------*/