Commit df9cd564 authored Feb 03, 2016 by Linus Walleij Committed by Stephen Boyd Feb 10, 2016

clk: versatile: mask VCO bits before writing



The Versatile syscon ICST driver OR:s the bits into place but
forgets to mask the previous value, making the code only work
if the register is zero or giving haphazard results. Mask the
19 bits used by the Versatile syscon interface register.

Regression caused and now fixed by yours truly.

Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-clk@vger.kernel.org
Fixes: 179c8fb3 ("clk: versatile-icst: convert to use regmap")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

parent 0e954fea

drivers/clk/versatile/clk-icst.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -78,6 +78,9 @@ static int vco_set(struct clk_icst *icst, struct icst_vco vco)
		ret = regmap_read(icst->map, icst->vcoreg_off, &val);
		if (ret)
		return ret;

		/* Mask the 18 bits used by the VCO */
		val &= ~0x7ffff;
		val \|= vco.v \| (vco.r << 9) \| (vco.s << 16);

		/* This magic unlocks the VCO so it can be controlled */