Commit df1deb67 authored Nov 28, 2007 by Julia Lawall Committed by Jaroslav Kysela Jan 31, 2008

[ALSA] sound/core/memalloc.c: Add missing pci_dev_put



There should be a pci_dev_put when breaking out of a loop that iterates
over calls to pci_get_device and similar functions.
In this case, the return under the initial if needs a pci_dev_put in the
same way that the return under the subsequent for loop has a pci_dev_put.
This was fixed using the following semantic patch.
// <smpl>
@@
type T;
identifier d;
expression e;
@@
T *d;
...
while ((d = \(pci_get_device\|pci_get_device_reverse\|pci_get_subsys\|pci_get_class\)(..., d)) != NULL)
  {... when != pci_dev_put(d)
       when != e = d
(
    return d;
|
+  pci_dev_put(d);
?  return ...;
)
...}
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>

parent 1005f66f

sound/core/memalloc.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -568,6 +568,7 @@ static ssize_t snd_mem_proc_write(struct file file, const char __user buffer,
		if (pci_set_dma_mask(pci, mask) < 0 \|\|
		pci_set_consistent_dma_mask(pci, mask) < 0) {
		printk(KERN_ERR "snd-page-alloc: cannot set DMA mask %lx for pci %04x:%04x\n", mask, vendor, device);
		pci_dev_put(pci);
		return count;
		}
		}