Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit df182977 authored by Thomas Renninger's avatar Thomas Renninger Committed by Dave Jones
Browse files

[CPUFREQ] powernow-k8 cleanup msg if BIOS does not export ACPI _PSS cpufreq data 



- Make the message shorter and easier to grep for
- Use printk_once instead of WARN_ONCE (functionality of these was mixed)

Signed-off-by: default avatarThomas Renninger <trenn@suse.de>
Cc: Langsdorf, Mark <mark.langsdorf@amd.com>
Signed-off-by: default avatarDave Jones <davej@redhat.com>
parent b14893a6

arch/x86/kernel/cpu/cpufreq/powernow-k8.c

+5 −14
Original line number Diff line number Diff line
@@ -1215,13 +1215,16 @@ static int powernowk8_verify(struct cpufreq_policy *pol) 
	return cpufreq_frequency_table_verify(pol, data->powernow_table);

}



static const char ACPI_PSS_BIOS_BUG_MSG[] =

	KERN_ERR FW_BUG PFX "No compatible ACPI _PSS objects found.\n"

	KERN_ERR FW_BUG PFX "Try again with latest BIOS.\n";



/* per CPU init entry point to the driver */

static int __cpuinit powernowk8_cpu_init(struct cpufreq_policy *pol)

{

	struct powernow_k8_data *data;

	cpumask_t oldmask;

	int rc;

	static int print_once;



	if (!cpu_online(pol->cpu))

		return -ENODEV;
@@ -1244,19 +1247,7 @@ static int __cpuinit powernowk8_cpu_init(struct cpufreq_policy *pol) 
		 * an UP version, and is deprecated by AMD.

		 */

		if (num_online_cpus() != 1) {

			/*

			 * Replace this one with print_once as soon as such a

			 * thing gets introduced

			 */

			if (!print_once) {

				WARN_ONCE(1, KERN_ERR FW_BUG PFX "Your BIOS "

					"does not provide ACPI _PSS objects "

					"in a way that Linux understands. "

					"Please report this to the Linux ACPI"

					" maintainers and complain to your "

					"BIOS vendor.\n");

				print_once++;

			}

			printk_once(ACPI_PSS_BIOS_BUG_MSG);

			goto err_out;

		}

		if (pol->cpu != 0) {