Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit deed62ed authored by Nick Piggin's avatar Nick Piggin Committed by Jens Axboe
Browse files

writeback: remove smp_mb(), it's not needed with list_add_tail_rcu() 



list_add_tail_rcu contains required barriers.

Signed-off-by: default avatarNick Piggin <npiggin@suse.de>
Signed-off-by: default avatarJens Axboe <jens.axboe@oracle.com>
parent 49db0414

fs/fs-writeback.c

+3 −3
Original line number Diff line number Diff line
@@ -151,10 +151,10 @@ static void bdi_queue_work(struct backing_dev_info *bdi, struct bdi_work *work) 
	BUG_ON(!bdi->wb_cnt);



	/*

	 * Make sure stores are seen before it appears on the list

	 * list_add_tail_rcu() contains the necessary barriers to

	 * make sure the above stores are seen before the item is

	 * noticed on the list

	 */

	smp_mb();



	spin_lock(&bdi->wb_lock);

	list_add_tail_rcu(&work->list, &bdi->work_list);

	spin_unlock(&bdi->wb_lock);