Commit dea5f099 authored Oct 31, 2012 by Nicholas Bellinger

target: Re-add explict zeroing of INQUIRY bounce buffer memory



This patch fixes a regression in spc_emulate_inquiry() code where the
local scope bounce buffer was no longer getting it's memory zeroed,
causing various problems with SCSI initiators that depend upon areas
of INQUIRY EVPD=0x83 payload having been zeroed.

This bug was introduced with the following v3.7-rc1 patch + CC'ed
stable commit:

commit ffe7b0e9
Author: Paolo Bonzini <pbonzini@redhat.com>
Date:   Fri Sep 7 17:30:38 2012 +0200

    target: support zero allocation length in INQUIRY

Go ahead and re-add the missing memset of bounce buffer memory to be
copied into the outgoing se_cmd descriptor kmapped SGL payload.

Reported-by: Kelsey Prantis <kelsey.prantis@intel.com>
Cc: Kelsey Prantis <kelsey.prantis@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Andy Grover <agrover@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

parent 1a1ff38c

drivers/target/target_core_spc.c

+2 −0

Original line number	Original line	Diff line number	Diff line
	@@ -605,6 +605,8 @@ static int spc_emulate_inquiry(struct se_cmd *cmd)
	unsigned char buf[SE_INQUIRY_BUF];		unsigned char buf[SE_INQUIRY_BUF];
	int p, ret;		int p, ret;

			memset(buf, 0, SE_INQUIRY_BUF);

	if (dev == tpg->tpg_virt_lun0.lun_se_dev)		if (dev == tpg->tpg_virt_lun0.lun_se_dev)
	buf[0] = 0x3f; /* Not connected */		buf[0] = 0x3f; /* Not connected */
	else		else