Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit de7aca16 authored by Ben Hutchings's avatar Ben Hutchings Committed by David S. Miller
Browse files

doc, net: Remove instruction to set net_device::trans_start 



Commit 08baf561 ('net:
txq_trans_update() helper') made it unnecessary for most drivers to
set net_device::trans_start (or netdev_queue::trans_start).

Signed-off-by: default avatarBen Hutchings <bhutchings@solarflare.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b3cf6545

Documentation/networking/driver.txt

+2 −5
Original line number Original line Diff line number Diff line
@@ -58,13 +58,10 @@ Transmit path guidelines: 
            TX_BUFFS_AVAIL(dp) > 0)

            TX_BUFFS_AVAIL(dp) > 0)

		netif_wake_queue(dp->dev);

		netif_wake_queue(dp->dev);





2) Do not forget to update netdev->trans_start to jiffies after

2) An ndo_start_xmit method must not modify the shared parts of a

   each new tx packet is given to the hardware.



3) An ndo_start_xmit method must not modify the shared parts of a

   cloned SKB.

   cloned SKB.





4) Do not forget that once you return 0 from your ndo_start_xmit

3) Do not forget that once you return 0 from your ndo_start_xmit

   method, it is your driver's responsibility to free up the SKB

   method, it is your driver's responsibility to free up the SKB

   and in some finite amount of time.

   and in some finite amount of time.