Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit de498c89 authored by Roland Dreier's avatar Roland Dreier Committed by David S. Miller
Browse files

cxgb4: Make unnecessarily global functions static 



Also put t4_write_indirect() inside "#if 0" to avoid a "defined but not
used" compile warning.

Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 62718b32

drivers/net/cxgb4/cxgb4.h

+0 −2
Original line number Diff line number Diff line
@@ -651,8 +651,6 @@ int t4_link_start(struct adapter *adap, unsigned int mbox, unsigned int port, 
		  struct link_config *lc);

int t4_restart_aneg(struct adapter *adap, unsigned int mbox, unsigned int port);

int t4_seeprom_wp(struct adapter *adapter, bool enable);

int t4_read_flash(struct adapter *adapter, unsigned int addr,

		  unsigned int nwords, u32 *data, int byte_oriented);

int t4_load_fw(struct adapter *adapter, const u8 *fw_data, unsigned int size);

int t4_check_fw_version(struct adapter *adapter);

int t4_prep_adapter(struct adapter *adapter);

drivers/net/cxgb4/sge.c

+1 −1
Original line number Diff line number Diff line
@@ -1471,7 +1471,7 @@ EXPORT_SYMBOL(cxgb4_pktgl_to_skb); 
 *	Releases the pages of a packet gather list.  We do not own the last

 *	page on the list and do not free it.

 */

void t4_pktgl_free(const struct pkt_gl *gl)

static void t4_pktgl_free(const struct pkt_gl *gl)

{

	int n;

	const skb_frag_t *p;

drivers/net/cxgb4/t4_hw.c

+12 −10
Original line number Diff line number Diff line
@@ -53,7 +53,7 @@ 
 *	at the time it indicated completion is stored there.  Returns 0 if the

 *	operation completes and	-EAGAIN	otherwise.

 */

int t4_wait_op_done_val(struct adapter *adapter, int reg, u32 mask,

static int t4_wait_op_done_val(struct adapter *adapter, int reg, u32 mask,

			       int polarity, int attempts, int delay, u32 *valp)

{

	while (1) {
@@ -109,9 +109,9 @@ void t4_set_reg_field(struct adapter *adapter, unsigned int addr, u32 mask, 
 *	Reads registers that are accessed indirectly through an address/data

 *	register pair.

 */

void t4_read_indirect(struct adapter *adap, unsigned int addr_reg,

		      unsigned int data_reg, u32 *vals, unsigned int nregs,

		      unsigned int start_idx)

static void t4_read_indirect(struct adapter *adap, unsigned int addr_reg,

			     unsigned int data_reg, u32 *vals,

			     unsigned int nregs, unsigned int start_idx)

{

	while (nregs--) {

		t4_write_reg(adap, addr_reg, start_idx);
@@ -120,6 +120,7 @@ void t4_read_indirect(struct adapter *adap, unsigned int addr_reg, 
	}

}



#if 0

/**

 *	t4_write_indirect - write indirectly addressed registers

 *	@adap: the adapter
@@ -132,7 +133,7 @@ void t4_read_indirect(struct adapter *adap, unsigned int addr_reg, 
 *	Writes a sequential block of registers that are accessed indirectly

 *	through an address/data register pair.

 */

void t4_write_indirect(struct adapter *adap, unsigned int addr_reg,

static void t4_write_indirect(struct adapter *adap, unsigned int addr_reg,

			      unsigned int data_reg, const u32 *vals,

			      unsigned int nregs, unsigned int start_idx)

{
@@ -141,6 +142,7 @@ void t4_write_indirect(struct adapter *adap, unsigned int addr_reg, 
		t4_write_reg(adap, data_reg, *vals++);

	}

}

#endif



/*

 * Get the reply to a mailbox command and store it in @rpl in big-endian order.
@@ -537,7 +539,7 @@ static int flash_wait_op(struct adapter *adapter, int attempts, int delay) 
 *	(i.e., big-endian), otherwise as 32-bit words in the platform's

 *	natural endianess.

 */

int t4_read_flash(struct adapter *adapter, unsigned int addr,

static int t4_read_flash(struct adapter *adapter, unsigned int addr,

			 unsigned int nwords, u32 *data, int byte_oriented)

{

	int ret;