Commit dd3b204a authored Jun 19, 2016 by Andy Shevchenko Committed by Linus Walleij Jun 23, 2016

gpio: intel-mid: switch to devm_gpiochip_add_data()

The error handling is not correct since the commit 3f7dbfd8 ("gpio:
intel-mid: switch to using gpiolib irqchip helpers"). Switch to devres API to
fix the potential resource leak.

Fixes: commit 3f7dbfd8 ("gpio: intel-mid: switch to using gpiolib irqchip helpers")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 771d899a

drivers/gpio/gpio-intel-mid.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -401,7 +401,7 @@ static int intel_gpio_probe(struct pci_dev *pdev,
		spin_lock_init(&priv->lock);

		pci_set_drvdata(pdev, priv);
		retval = gpiochip_add_data(&priv->chip, priv);
		retval = devm_gpiochip_add_data(&pdev->dev, &priv->chip, priv);
		if (retval) {
		dev_err(&pdev->dev, "gpiochip_add error %d\n", retval);
		return retval;