Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dceab655 authored by Christof Schmitt's avatar Christof Schmitt Committed by James Bottomley
Browse files

[SCSI] zfcp: Add comments to switch/case fallthroughs 



Add comments where there is a deliberate fall through in switch/case
statements. This makes some code checkers happy and makes it clear
that there is no missing break statement.

Reviewed-by: default avatarSwen Schillig <swen@vnet.ibm.com>
Signed-off-by: default avatarChristof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
parent bc90c863

drivers/s390/scsi/zfcp_erp.c

+1 −0
Original line number Diff line number Diff line
@@ -880,6 +880,7 @@ static int zfcp_erp_port_strategy_open_common(struct zfcp_erp_action *act) 
				zfcp_port_put(port);

			return ZFCP_ERP_CONTINUES;

		}

		/* fall through */

	case ZFCP_ERP_STEP_NAMESERVER_LOOKUP:

		if (!port->d_id)

			return ZFCP_ERP_FAILED;

drivers/s390/scsi/zfcp_fsf.c

+5 −0
Original line number Diff line number Diff line
@@ -526,6 +526,7 @@ static int zfcp_fsf_exchange_config_evaluate(struct zfcp_fsf_req *req) 
		break;

	case FSF_TOPO_AL:

		fc_host_port_type(shost) = FC_PORTTYPE_NLPORT;

		/* fall through */

	default:

		dev_err(&adapter->ccw_device->dev,

			"Unknown or unsupported arbitrated loop "
@@ -897,6 +898,7 @@ static void zfcp_fsf_abort_fcp_command_handler(struct zfcp_fsf_req *req) 
		switch (fsq->word[0]) {

		case FSF_SQ_INVOKE_LINK_TEST_PROCEDURE:

			zfcp_test_link(unit->port);

			/* fall through */

		case FSF_SQ_ULP_DEPENDENT_ERP_REQUIRED:

			req->status |= ZFCP_STATUS_FSFREQ_ERROR;

			break;
@@ -993,6 +995,7 @@ static void zfcp_fsf_send_ct_handler(struct zfcp_fsf_req *req) 
		break;

	case FSF_PORT_HANDLE_NOT_VALID:

		zfcp_erp_adapter_reopen(adapter, 0, "fsscth1", req);

		/* fall through */

	case FSF_GENERIC_COMMAND_REJECTED:

	case FSF_PAYLOAD_SIZE_MISMATCH:

	case FSF_REQUEST_SIZE_TOO_LARGE:
@@ -1590,8 +1593,10 @@ static void zfcp_fsf_open_wka_port_handler(struct zfcp_fsf_req *req) 
	case FSF_MAXIMUM_NUMBER_OF_PORTS_EXCEEDED:

		dev_warn(&req->adapter->ccw_device->dev,

			 "Opening WKA port 0x%x failed\n", wka_port->d_id);

		/* fall through */

	case FSF_ADAPTER_STATUS_AVAILABLE:

		req->status |= ZFCP_STATUS_FSFREQ_ERROR;

		/* fall through */

	case FSF_ACCESS_DENIED:

		wka_port->status = ZFCP_WKA_PORT_OFFLINE;

		break;