Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dc0c32c9 authored by Wolfram Sang's avatar Wolfram Sang Committed by Greg Kroah-Hartman
Browse files

usb: usb-skeleton: don't print on ENOMEM 



All kmalloc-based functions print enough information on failures.

Signed-off-by: default avatarWolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fd233925

drivers/usb/usb-skeleton.c

+2 −7
Original line number Diff line number Diff line
@@ -499,10 +499,8 @@ static int skel_probe(struct usb_interface *interface, 


	/* allocate memory for our device state and initialize it */

	dev = kzalloc(sizeof(*dev), GFP_KERNEL);

	if (!dev) {

		dev_err(&interface->dev, "Out of memory\n");

	if (!dev)

		goto error;

	}

	kref_init(&dev->kref);

	sema_init(&dev->limit_sem, WRITES_IN_FLIGHT);

	mutex_init(&dev->io_mutex);
@@ -526,11 +524,8 @@ static int skel_probe(struct usb_interface *interface, 
			dev->bulk_in_size = buffer_size;

			dev->bulk_in_endpointAddr = endpoint->bEndpointAddress;

			dev->bulk_in_buffer = kmalloc(buffer_size, GFP_KERNEL);

			if (!dev->bulk_in_buffer) {

				dev_err(&interface->dev,

					"Could not allocate bulk_in_buffer\n");

			if (!dev->bulk_in_buffer)

				goto error;

			}

			dev->bulk_in_urb = usb_alloc_urb(0, GFP_KERNEL);

			if (!dev->bulk_in_urb)

				goto error;