Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dbf4fcad authored by Alan Stern's avatar Alan Stern Committed by Greg Kroah-Hartman
Browse files

[PATCH] UHCI: Don't log short transfers 



Even when the URB_SHORT_NOT_OK flag is set, a short transfer shouldn't
generate a debugging log message.  Especially not one with the confusing
claim that the transfer "failed with status 0".  This patch (as627)
fixes that behavior in uhci-hcd.

Signed-off-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 8d402e1a

drivers/usb/host/uhci-q.c

+1 −1
Original line number Diff line number Diff line
@@ -922,7 +922,6 @@ static int uhci_result_common(struct uhci_hcd *uhci, struct urb *urb) 
td_error:

	ret = uhci_map_status(status, uhci_packetout(td_token(td)));



err:

	if ((debug == 1 && ret != -EPIPE) || debug > 1) {

		/* Some debugging code */

		dev_dbg(uhci_dev(uhci), "%s: failed with status %x\n",
@@ -934,6 +933,7 @@ static int uhci_result_common(struct uhci_hcd *uhci, struct urb *urb) 
			lprintk(errbuf);

		}

	}

err:



	/* Note that the queue has stopped and save the next toggle value */

	urbp->qh->element = UHCI_PTR_TERM;