Commit db7f3ded authored Aug 04, 2007 by Jesper Juhl Committed by Dave Airlie Aug 06, 2007

efficeon-agp leaks 'struct agp_bridge_data' in error paths of agp_efficeon_probe()



(This is a resend of a patch originally submitted on 24-Jul-2007 00:14)

Ok, this is something the coverity checker found (CID: 1813).
I'm not at all intimate with this code, so I'm not sure if this
attempt at a fix is correct (but at least it compiles).

Please look it over and NACK if bad or merge if good ;-)

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Dave Airlie <airlied@linux.ie>

parent d4ac2477

drivers/char/agp/efficeon-agp.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -375,6 +375,7 @@ static int __devinit agp_efficeon_probe(struct pci_dev *pdev,
		if (!r->start && r->end) {
		if (pci_assign_resource(pdev, 0)) {
		printk(KERN_ERR PFX "could not assign resource 0\n");
		agp_put_bridge(bridge);
		return -ENODEV;
		}
		}
		@@ -386,6 +387,7 @@ static int __devinit agp_efficeon_probe(struct pci_dev *pdev,
		*/
		if (pci_enable_device(pdev)) {
		printk(KERN_ERR PFX "Unable to Enable PCI device\n");
		agp_put_bridge(bridge);
		return -ENODEV;
		}