Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit db671a8e authored by Al Viro's avatar Al Viro
Browse files

don't bother with most of the bad_file_ops methods 



Only ->open() should be there (always failing, of course).  We never
replace ->f_op of an already opened struct file, so there's no way
for any of those methods to be called.

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 28444a2b

fs/bad_inode.c

+0 −147
Original line number Diff line number Diff line
@@ -15,161 +15,14 @@ 
#include <linux/namei.h>

#include <linux/poll.h>





static loff_t bad_file_llseek(struct file *file, loff_t offset, int whence)

{

	return -EIO;

}



static ssize_t bad_file_read(struct file *filp, char __user *buf,

			size_t size, loff_t *ppos)

{

        return -EIO;

}



static ssize_t bad_file_write(struct file *filp, const char __user *buf,

			size_t siz, loff_t *ppos)

{

        return -EIO;

}



static ssize_t bad_file_aio_read(struct kiocb *iocb, const struct iovec *iov,

			unsigned long nr_segs, loff_t pos)

{

	return -EIO;

}



static ssize_t bad_file_aio_write(struct kiocb *iocb, const struct iovec *iov,

			unsigned long nr_segs, loff_t pos)

{

	return -EIO;

}



static int bad_file_readdir(struct file *file, struct dir_context *ctx)

{

	return -EIO;

}



static unsigned int bad_file_poll(struct file *filp, poll_table *wait)

{

	return POLLERR;

}



static long bad_file_unlocked_ioctl(struct file *file, unsigned cmd,

			unsigned long arg)

{

	return -EIO;

}



static long bad_file_compat_ioctl(struct file *file, unsigned int cmd,

			unsigned long arg)

{

	return -EIO;

}



static int bad_file_mmap(struct file *file, struct vm_area_struct *vma)

{

	return -EIO;

}



static int bad_file_open(struct inode *inode, struct file *filp)

{

	return -EIO;

}



static int bad_file_flush(struct file *file, fl_owner_t id)

{

	return -EIO;

}



static int bad_file_release(struct inode *inode, struct file *filp)

{

	return -EIO;

}



static int bad_file_fsync(struct file *file, loff_t start, loff_t end,

			  int datasync)

{

	return -EIO;

}



static int bad_file_aio_fsync(struct kiocb *iocb, int datasync)

{

	return -EIO;

}



static int bad_file_fasync(int fd, struct file *filp, int on)

{

	return -EIO;

}



static int bad_file_lock(struct file *file, int cmd, struct file_lock *fl)

{

	return -EIO;

}



static ssize_t bad_file_sendpage(struct file *file, struct page *page,

			int off, size_t len, loff_t *pos, int more)

{

	return -EIO;

}



static unsigned long bad_file_get_unmapped_area(struct file *file,

				unsigned long addr, unsigned long len,

				unsigned long pgoff, unsigned long flags)

{

	return -EIO;

}



static int bad_file_check_flags(int flags)

{

	return -EIO;

}



static int bad_file_flock(struct file *filp, int cmd, struct file_lock *fl)

{

	return -EIO;

}



static ssize_t bad_file_splice_write(struct pipe_inode_info *pipe,

			struct file *out, loff_t *ppos, size_t len,

			unsigned int flags)

{

	return -EIO;

}



static ssize_t bad_file_splice_read(struct file *in, loff_t *ppos,

			struct pipe_inode_info *pipe, size_t len,

			unsigned int flags)

{

	return -EIO;

}



static const struct file_operations bad_file_ops =

{

	.llseek		= bad_file_llseek,

	.read		= bad_file_read,

	.write		= bad_file_write,

	.aio_read	= bad_file_aio_read,

	.aio_write	= bad_file_aio_write,

	.iterate	= bad_file_readdir,

	.poll		= bad_file_poll,

	.unlocked_ioctl	= bad_file_unlocked_ioctl,

	.compat_ioctl	= bad_file_compat_ioctl,

	.mmap		= bad_file_mmap,

	.open		= bad_file_open,

	.flush		= bad_file_flush,

	.release	= bad_file_release,

	.fsync		= bad_file_fsync,

	.aio_fsync	= bad_file_aio_fsync,

	.fasync		= bad_file_fasync,

	.lock		= bad_file_lock,

	.sendpage	= bad_file_sendpage,

	.get_unmapped_area = bad_file_get_unmapped_area,

	.check_flags	= bad_file_check_flags,

	.flock		= bad_file_flock,

	.splice_write	= bad_file_splice_write,

	.splice_read	= bad_file_splice_read,

};



static int bad_inode_create (struct inode *dir, struct dentry *dentry,