Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dacae5a1 authored by Denis Efremov's avatar Denis Efremov Committed by Takashi Iwai
Browse files

ALSA: ali5451: remove irq enabling in pointer callback 



snd_ali_pointer function is called with local
interrupts disabled. However it seems very strange to
reenable them in such way.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: default avatarDenis Efremov <yefremov.denis@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent f49a59c4

sound/pci/ali5451/ali5451.c

+1 −1
Original line number Diff line number Diff line
@@ -1435,7 +1435,7 @@ static snd_pcm_uframes_t snd_ali_pointer(struct snd_pcm_substream *substream) 


	spin_lock(&codec->reg_lock);

	if (!pvoice->running) {

		spin_unlock_irq(&codec->reg_lock);

		spin_unlock(&codec->reg_lock);

		return 0;

	}

	outb(pvoice->number, ALI_REG(codec, ALI_GC_CIR));