Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d9fb5c09 authored by Jeff Layton's avatar Jeff Layton Committed by Steve French
Browse files

cifs: no need to use rcu_assign_pointer on immutable keys 



cifs: no need to use rcu_assign_pointer on immutable keys

Neither keytype in use by CIFS has an "update" method. This means that
the keys are immutable once instantiated. We don't need to use RCU
to set the payload data pointers.

Signed-off-by: default avatarJeff Layton <jlayton@redhat.com>
Signed-off-by: default avatarSteve French <sfrench@us.ibm.com>
parent 5144ebf4

fs/cifs/cifs_spnego.c

+1 −1
Original line number Diff line number Diff line
@@ -41,7 +41,7 @@ cifs_spnego_key_instantiate(struct key *key, const void *data, size_t datalen) 


	/* attach the data */

	memcpy(payload, data, datalen);

	rcu_assign_pointer(key->payload.data, payload);

	key->payload.data = payload;

	ret = 0;



error:

fs/cifs/dns_resolve.c

+1 −1
Original line number Diff line number Diff line
@@ -78,7 +78,7 @@ dns_resolver_instantiate(struct key *key, const void *data, 
	}



	key->type_data.x[0] = datalen;

	rcu_assign_pointer(key->payload.data, ip);

	key->payload.data = ip;



	return rc;

}