Commit d9a90a31 authored Jun 13, 2013 by Jason Wang Committed by David S. Miller Jun 13, 2013

macvtap: slient sparse warnings



This patch silents the following sparse warnings:

drivers/net/macvtap.c:98:9: warning: incorrect type in assignment (different
address spaces)
drivers/net/macvtap.c:98:9:    expected struct macvtap_queue *<noident>
drivers/net/macvtap.c:98:9:    got struct macvtap_queue [noderef]
<asn:4>*<noident>
drivers/net/macvtap.c:120:9: warning: incorrect type in assignment (different
address spaces)
drivers/net/macvtap.c:120:9:    expected struct macvtap_queue *<noident>
drivers/net/macvtap.c:120:9:    got struct macvtap_queue [noderef]
<asn:4>*<noident>
drivers/net/macvtap.c:151:22: error: incompatible types in comparison expression
(different address spaces)
drivers/net/macvtap.c:233:23: error: incompatible types in comparison expression
(different address spaces)
drivers/net/macvtap.c:243:23: error: incompatible types in comparison expression
(different address spaces)
drivers/net/macvtap.c:247:15: error: incompatible types in comparison expression
(different address spaces)
  CC [M]  drivers/net/macvtap.o
drivers/net/macvlan.c:232:24: error: incompatible types in comparison expression
(different address spaces)

Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 2c928e0e

drivers/net/macvtap.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -429,7 +429,7 @@ static int macvtap_open(struct inode inode, struct file file)
		if (!q)
		goto out;

		q->sock.wq = &q->wq;
		RCU_INIT_POINTER(q->sock.wq, &q->wq);
		init_waitqueue_head(&q->wq.wait);
		q->sock.type = SOCK_RAW;
		q->sock.state = SS_CONNECTED;

include/linux/if_macvlan.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -70,7 +70,7 @@ struct macvlan_dev {
		int (receive)(struct sk_buff skb);
		int (forward)(struct net_device dev, struct sk_buff *skb);
		/* This array tracks active taps. */
		struct macvtap_queue *taps[MAX_MACVTAP_QUEUES];
		struct macvtap_queue __rcu *taps[MAX_MACVTAP_QUEUES];
		/* This list tracks all taps (both enabled and disabled) */
		struct list_head queue_list;
		int numvtaps;