Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d96336b0 authored by Josh Hunt's avatar Josh Hunt Committed by Jan Kara
Browse files

ext2: Resolve 'dereferencing pointer to incomplete type' when enabling EXT2_XATTR_DEBUG 



When I enable EXT2_XATTR_DEBUG in fs/ext2/xattr.c I get a build error stating
the following:

  CC      fs/ext2/xattr.o
fs/ext2/xattr.c: In function 'ext2_xattr_cache_insert':
fs/ext2/xattr.c:841: error: dereferencing pointer to incomplete type
fs/ext2/xattr.c:846: error: dereferencing pointer to incomplete type
make[2]: *** [fs/ext2/xattr.o] Error 1
make[1]: *** [fs/ext2] Error 2
make: *** [fs] Error 2

These lines reference ext2_xattr_cache->c_entry_count which is defined
in struct mb_cache. struct mb_cache is currently only defined in fs/mbcache.c.
Moving struct mb_cache definition to include/linux/mbcache.h to resolve the
issue.

Signed-off-by: default avatarJosh Hunt <johunt@akamai.com>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
parent 8057b965

fs/mbcache.c

+0 −12
Original line number Original line Diff line number Diff line
@@ -76,18 +76,6 @@ EXPORT_SYMBOL(mb_cache_entry_find_first); 
EXPORT_SYMBOL(mb_cache_entry_find_next);

EXPORT_SYMBOL(mb_cache_entry_find_next);

#endif

#endif





struct mb_cache {

	struct list_head		c_cache_list;

	const char			*c_name;

	atomic_t			c_entry_count;

	int				c_max_entries;

	int				c_bucket_bits;

	struct kmem_cache		*c_entry_cache;

	struct list_head		*c_block_hash;

	struct list_head		*c_index_hash;

};





/*

/*

 * Global data: list of all mbcache's, lru list, and a spinlock for

 * Global data: list of all mbcache's, lru list, and a spinlock for

 * accessing cache data structures on SMP machines. The lru list is

 * accessing cache data structures on SMP machines. The lru list is

include/linux/mbcache.h

+11 −0
Original line number Original line Diff line number Diff line
@@ -18,6 +18,17 @@ struct mb_cache_entry { 
	} e_index;

	} e_index;

};

};





struct mb_cache {

	struct list_head		c_cache_list;

	const char			*c_name;

	atomic_t			c_entry_count;

	int				c_max_entries;

	int				c_bucket_bits;

	struct kmem_cache		*c_entry_cache;

	struct list_head		*c_block_hash;

	struct list_head		*c_index_hash;

};



/* Functions on caches */

/* Functions on caches */





struct mb_cache *mb_cache_create(const char *, int);

struct mb_cache *mb_cache_create(const char *, int);