Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d95e3cae authored by Peter Hurley's avatar Peter Hurley Committed by Greg Kroah-Hartman
Browse files

usb: serial: Remove unused tty->hw_stopped 



The tty core does not test tty->hw_stopped; remove from drivers
which don't test it themselves.

Acked-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarPeter Hurley <peter@hurleysoftware.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d01f4d18

drivers/usb/serial/digi_acceleport.c

+1 −6
Original line number Diff line number Diff line
@@ -834,7 +834,6 @@ static void digi_set_termios(struct tty_struct *tty, 
			arg |= DIGI_OUTPUT_FLOW_CONTROL_CTS;

		} else {

			arg &= ~DIGI_OUTPUT_FLOW_CONTROL_CTS;

			tty->hw_stopped = 0;

		}



		buf[i++] = DIGI_CMD_SET_OUTPUT_FLOW_CONTROL;
@@ -1500,15 +1499,11 @@ static int digi_read_oob_callback(struct urb *urb) 
			if (val & DIGI_READ_INPUT_SIGNALS_CTS) {

				priv->dp_modem_signals |= TIOCM_CTS;

				/* port must be open to use tty struct */

				if (rts) {

					tty->hw_stopped = 0;

				if (rts)

					tty_port_tty_wakeup(&port->port);

				}

			} else {

				priv->dp_modem_signals &= ~TIOCM_CTS;

				/* port must be open to use tty struct */

				if (rts)

					tty->hw_stopped = 1;

			}

			if (val & DIGI_READ_INPUT_SIGNALS_DSR)

				priv->dp_modem_signals |= TIOCM_DSR;

drivers/usb/serial/io_ti.c

+1 −6
Original line number Diff line number Diff line
@@ -1456,12 +1456,8 @@ static void handle_new_msr(struct edgeport_port *edge_port, __u8 msr) 
	tty = tty_port_tty_get(&edge_port->port->port);

	/* handle CTS flow control */

	if (tty && C_CRTSCTS(tty)) {

		if (msr & EDGEPORT_MSR_CTS) {

			tty->hw_stopped = 0;

		if (msr & EDGEPORT_MSR_CTS)

			tty_wakeup(tty);

		} else {

			tty->hw_stopped = 1;

		}

	}

	tty_kref_put(tty);

}
@@ -2177,7 +2173,6 @@ static void change_port_settings(struct tty_struct *tty, 
		dev_dbg(dev, "%s - RTS/CTS is enabled\n", __func__);

	} else {

		dev_dbg(dev, "%s - RTS/CTS is disabled\n", __func__);

		tty->hw_stopped = 0;

		restart_read(edge_port);

	}

drivers/usb/serial/ti_usb_3410_5052.c

+1 −6
Original line number Diff line number Diff line
@@ -773,7 +773,6 @@ static void ti_set_termios(struct tty_struct *tty, 
			config->wFlags |= TI_UART_ENABLE_RTS_IN;

		config->wFlags |= TI_UART_ENABLE_CTS_OUT;

	} else {

		tty->hw_stopped = 0;

		ti_restart_read(tport, tty);

	}
@@ -1291,12 +1290,8 @@ static void ti_handle_new_msr(struct ti_port *tport, __u8 msr) 
	/* handle CTS flow control */

	tty = tty_port_tty_get(&tport->tp_port->port);

	if (tty && C_CRTSCTS(tty)) {

		if (msr & TI_MSR_CTS) {

			tty->hw_stopped = 0;

		if (msr & TI_MSR_CTS)

			tty_wakeup(tty);

		} else {

			tty->hw_stopped = 1;

		}

	}

	tty_kref_put(tty);

}