Commit d939b52a authored Mar 24, 2015 by Andrey Ryabinin Committed by Jesper Nilsson Mar 25, 2015

cris: fix integer overflow in ELF_ET_DYN_BASE



Almost all arches define ELF_ET_DYN_BASE as 2/3 of TASK_SIZE.
Though it seems that some architectures do this in a wrong way.
The problem is that 2*TASK_SIZE may overflow 32-bits so
the real ELF_ET_DYN_BASE becomes wrong.
Fix this overflow by dividing TASK_SIZE prior to multiplying:
	(TASK_SIZE / 3 * 2)

Signed-off-by: Andrey Ryabinin <a.ryabinin@samsung.com>
Signed-off-by: Jesper Nilsson <jespern@axis.com>

parent d3dad475

arch/cris/include/asm/elf.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -71,7 +71,7 @@ typedef unsigned long elf_fpregset_t;
		the loader. We need to make sure that it is out of the way of the program
		that it will "exec", and that there is sufficient room for the brk. */

		#define ELF_ET_DYN_BASE (2 * TASK_SIZE / 3)
		#define ELF_ET_DYN_BASE (TASK_SIZE / 3 * 2)

		/* This yields a mask that user programs can use to figure out what
		instruction set this CPU supports. This could be done in user space,