Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d791d413 authored by Olaf Kirch's avatar Olaf Kirch Committed by Linus Torvalds
Browse files

DVB: dvb-usb-remote - fix oops when changing keymap 

DVB USB remotes do not support changing keycode maps but set
input_dev->keycodesize and input_dev->keycodemax without setting
input_dev->keycode. This causes kernel oops when user tries to
look up (or change) current keymap.

While the proper fix would be to make remotes handle keymap changes
we'll just remove keycodemax and keycodesize initialization so
EVIOCGKEYCODE and EVIOCSKEYCODE will simply return -EINVAL.

http://bugzilla.kernel.org/show_bug.cgi?id=8312



Signed-off-by: default avatar <olaf.kirch@oracle.com>
Signed-off-by: default avatarDmitry Torokhov <dtor@mail.ru>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent b1847a04

drivers/media/dvb/dvb-usb/dvb-usb-remote.c

+0 −2
Original line number Diff line number Diff line
@@ -107,8 +107,6 @@ int dvb_usb_remote_init(struct dvb_usb_device *d) 
		return -ENOMEM;



	input_dev->evbit[0] = BIT(EV_KEY);

	input_dev->keycodesize = sizeof(unsigned char);

	input_dev->keycodemax = KEY_MAX;

	input_dev->name = "IR-receiver inside an USB DVB receiver";

	input_dev->phys = d->rc_phys;

	usb_to_input_id(d->udev, &input_dev->id);