Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d785fdb5 authored by Laurent Pinchart's avatar Laurent Pinchart
Browse files

sh-pfc: Don't take the sh_pfc spinlock in sh_pfc_map_gpios() 



The sh_pfc_map_gpios() function is only called at initialization time
when no other task can access the sh_pfc fields. Don't protect the
operation with a spinlock.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent e3e89ae4

drivers/pinctrl/sh-pfc/pinctrl.c

+0 −5
Original line number Diff line number Diff line
@@ -334,7 +334,6 @@ static void sh_pfc_map_one_gpio(struct sh_pfc *pfc, struct sh_pfc_pinctrl *pmx, 
/* pinmux ranges -> pinctrl pin descs */

static int sh_pfc_map_gpios(struct sh_pfc *pfc, struct sh_pfc_pinctrl *pmx)

{

	unsigned long flags;

	int i;



	pmx->nr_pads = pfc->info->last_gpio - pfc->info->first_gpio + 1;
@@ -346,8 +345,6 @@ static int sh_pfc_map_gpios(struct sh_pfc *pfc, struct sh_pfc_pinctrl *pmx) 
		return -ENOMEM;

	}



	spin_lock_irqsave(&pfc->lock, flags);



	/*

	 * We don't necessarily have a 1:1 mapping between pin and linux

	 * GPIO number, as the latter maps to the associated enum_id.
@@ -368,8 +365,6 @@ static int sh_pfc_map_gpios(struct sh_pfc *pfc, struct sh_pfc_pinctrl *pmx) 
		sh_pfc_map_one_gpio(pfc, pmx, gpio, i);

	}



	spin_unlock_irqrestore(&pfc->lock, flags);



	return 0;

}