Commit d73f1e3c authored Jun 21, 2006 by Philip Craig Committed by Jeff Garzik Jun 22, 2006

[PATCH] 8139cp: fix eeprom read command length



The read command for the 93C46/93C56 EEPROMS should be 3 bits plus
the address.  This doesn't appear to affect the operation of the
read command, but similar errors for write commands do cause failures.

Signed-off-by: Philip Craig <philipc@snapgear.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

parent fc13dcae

drivers/net/8139cp.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1628,7 +1628,7 @@ static int read_eeprom (void __iomem *ioaddr, int location, int addr_len)
		eeprom_delay ();

		/* Shift the read command bits out. */
		for (i = 4 + addr_len; i >= 0; i--) {
		for (i = 3 + addr_len - 1; i >= 0; i--) {
		int dataval = (read_cmd & (1 << i)) ? EE_DATA_WRITE : 0;
		writeb (EE_ENB \| dataval, ee_addr);
		eeprom_delay ();