Commit d6b09e75 authored Jul 31, 2012 by Akinobu Mita Committed by Linus Torvalds Jul 31, 2012

fault-injection: fix failcmd.sh warning



"fault-injection: add tool to run command with failslab or
fail_page_alloc" added tools/testing/fault-injection/failcmd.sh to make it
easier to inject slab/page allocation failures by fault injection.

failcmd.sh prints the following warning when running with arguments
for command.

	# ./failcmd.sh echo aaa
	failcmd.sh: line 209: [: echo: binary operator expected
	aaa

This warning is caused by an improper check whether at least one
parameter is left after parsing command options.

Fix it by testing the length of $1 instead of $@

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 2e3ee613

tools/testing/fault-injection/failcmd.sh

+1 −1

Original line number	Diff line number	Diff line
		@@ -206,7 +206,7 @@ while true; do
		esac
		done

		[ -z "$@" ] && exit 0
		[ -z "$1" ] && exit 0

		echo $oom_kill_allocating_task > /proc/sys/vm/oom_kill_allocating_task
		echo $task_filter > $FAULTATTR/task-filter