Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d63e51b3 authored by Gavin Shan's avatar Gavin Shan Committed by Michael Ellerman
Browse files

powerpc/powernv: Pass CPU-endian PE number to opal_pci_eeh_freeze_clear() 



The PE number (@frozen_pe_no), filled by opal_pci_next_error() is in
big-endian format. It should be converted to CPU-endian before it is
passed to opal_pci_eeh_freeze_clear() when clearing the frozen state if
the PE is invalid one. As Michael Ellerman pointed out, the issue is
also detected by sparse:

  eeh-powernv.c:1541:41: warning: incorrect type in argument 2 (different base types)

This passes CPU-endian PE number to opal_pci_eeh_freeze_clear() and it
should be part of commit <0f36db77> ("powerpc/eeh: Fix wrong printed
PE number"), which was merged to 4.3 kernel.

Fixes: 71b540ad ("powerpc/powernv: Don't escalate non-existing frozen PE")
Cc: stable@vger.kernel.org # v4.3+
Suggested-by: default avatarPaul Mackerras <paulus@samba.org>
Signed-off-by: default avatarGavin Shan <gwshan@linux.vnet.ibm.com>
Reviewed-by: default avatarRussell Currey <ruscur@russell.cc>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent 39f0d6fb

arch/powerpc/platforms/powernv/eeh-powernv.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -1546,7 +1546,7 @@ static int pnv_eeh_next_error(struct eeh_pe **pe) 




				/* Try best to clear it */

				/* Try best to clear it */

				opal_pci_eeh_freeze_clear(phb->opal_id,

				opal_pci_eeh_freeze_clear(phb->opal_id,

					frozen_pe_no,

					be64_to_cpu(frozen_pe_no),

					OPAL_EEH_ACTION_CLEAR_FREEZE_ALL);

					OPAL_EEH_ACTION_CLEAR_FREEZE_ALL);

				ret = EEH_NEXT_ERR_NONE;

				ret = EEH_NEXT_ERR_NONE;

			} else if ((*pe)->state & EEH_PE_ISOLATED ||

			} else if ((*pe)->state & EEH_PE_ISOLATED ||