Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d631b94e authored by stephen hemminger's avatar stephen hemminger Committed by David S. Miller
Browse files

virtio: change comment in transmit 



The original comment was not really informative or funny
as well as sexist. Replace it with a better explanation of
why the driver does stop and what the impacts are.

Signed-off-by: default avatarStephen Hemminger <stephen@networkplumber.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 835c3d9b

drivers/net/virtio_net.c

+6 −2
Original line number Diff line number Diff line
@@ -939,8 +939,12 @@ static netdev_tx_t start_xmit(struct sk_buff *skb, struct net_device *dev) 
	skb_orphan(skb);

	nf_reset(skb);



	/* Apparently nice girls don't return TX_BUSY; stop the queue

	 * before it gets out of hand.  Naturally, this wastes entries. */

	/* It is better to stop queue if running out of space

	 * instead of forcing queuing layer to requeue the skb

	 * by returning TX_BUSY (and cause a BUG message).

	 * Since most packets only take 1 or 2 ring slots

	 * this means 16 slots are typically wasted.

	 */

	if (sq->vq->num_free < 2+MAX_SKB_FRAGS) {

		netif_stop_subqueue(dev, qnum);

		if (unlikely(!virtqueue_enable_cb_delayed(sq->vq))) {