Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d601744d authored by Peter Hurley's avatar Peter Hurley Committed by Greg Kroah-Hartman
Browse files

serial: 8250: Reduce expr in 8250 irq handler 



If !up->dma == F, then up->dma == T and can be elided from the
(up->dma && up->dma->tx_err) sub-expression.

Signed-off-by: default avatarPeter Hurley <peter@hurleysoftware.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a86f50ed

drivers/tty/serial/8250/8250_port.c

+1 −2
Original line number Diff line number Diff line
@@ -1811,8 +1811,7 @@ int serial8250_handle_irq(struct uart_port *port, unsigned int iir) 
			status = serial8250_rx_chars(up, status);

	}

	serial8250_modem_status(up);

	if ((!up->dma || (up->dma && up->dma->tx_err)) &&

	    (status & UART_LSR_THRE))

	if ((!up->dma || up->dma->tx_err) && (status & UART_LSR_THRE))

		serial8250_tx_chars(up);



	spin_unlock_irqrestore(&port->lock, flags);