Commit d551c4c4 authored Jul 19, 2013 by Lee Jones

mfd: ab8500-debugfs: Apply a check for -ENOMEM after allocating memory for event name

The AB8500 debugfs driver allocates memory to contain the name of a new sysfs
entry, but fails to apply the proper post-allocation checks. If the device
were to run out of memory, the allocation would return NULL. Without the
correct checks the driver will continue to populate address NULL with the
specified device name which would obviously cause a pointer dereference Oops.

Signed-off-by: Lee Jones <lee.jones@linaro.org>

parent f840e23b

drivers/mfd/ab8500-debugfs.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -2804,6 +2804,9 @@ static ssize_t ab8500_subscribe_write(struct file *file,
		return -ENOMEM;

		event_name[irq_index] = kmalloc(count, GFP_KERNEL);
		if (!event_name[irq_index])
		return -ENOMEM;

		sprintf(event_name[irq_index], "%lu", user_val);
		dev_attr[irq_index]->show = show_irq;
		dev_attr[irq_index]->store = NULL;