Commit d2f3a398 authored Jul 03, 2013 by Jingoo Han Committed by Linus Torvalds Jul 03, 2013

rtc: rtc-mxc: remove unnecessary platform_set_drvdata()



The driver core clears the driver data to NULL after device_release or
on probe failure, since commit 0998d063 ("device-core: Ensure drvdata
= NULL when no driver is bound").  Thus, it is not needed to manually
clear the device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent e3aa7526

drivers/rtc/rtc-mxc.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -443,15 +443,13 @@ static int mxc_rtc_probe(struct platform_device *pdev)
		THIS_MODULE);
		if (IS_ERR(rtc)) {
		ret = PTR_ERR(rtc);
		goto exit_clr_drvdata;
		goto exit_put_clk;
		}

		pdata->rtc = rtc;

		return 0;

		exit_clr_drvdata:
		platform_set_drvdata(pdev, NULL);
		exit_put_clk:
		clk_disable_unprepare(pdata->clk);

		@@ -465,7 +463,6 @@ static int mxc_rtc_remove(struct platform_device *pdev)
		struct rtc_plat_data *pdata = platform_get_drvdata(pdev);

		clk_disable_unprepare(pdata->clk);
		platform_set_drvdata(pdev, NULL);

		return 0;
		}