Commit d2d371ae authored Aug 16, 2016 by Thierry Reding Committed by David S. Miller Aug 17, 2016

net: ipconfig: Fix more use after free



While commit 9c706a49 ("net: ipconfig: fix use after free") avoids
the use after free, the resulting code still ends up calling both the
ic_setup_if() and ic_setup_routes() after calling ic_close_devs(), and
access to the device is still required.

Move the call to ic_close_devs() to the very end of the function.

Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 00062a93

net/ipv4/ipconfig.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -1530,12 +1530,14 @@ static int __init ip_auto_config(void)
		* Close all network devices except the device we've
		* autoconfigured and set up routes.
		*/
		ic_close_devs();
		if (ic_setup_if() < 0 \|\| ic_setup_routes() < 0)
		return -1;
		err = -1;
		else
		err = 0;

		ic_close_devs();

		return 0;
		return err;
		}

		late_initcall(ip_auto_config);