Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d2b213f7 authored by Alan Cox's avatar Alan Cox Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (7729): Fix VIDIOCGAP corruption in ivtv 



Frank Bennett reported that ivtv was causing skype to crash. With help
from one of their developers he showed it was a kernel problem.
VIDIOCGCAP copies a name into a fixed length buffer - ivtv uses names
that are too long and does not truncate them so corrupts a few bytes of
the app data area.

Possibly the names also want trimming but for now this should fix the
corruption case.

Signed-off-by: default avatarAlan Cox <alan@redhat.com>
Signed-off-by: default avatarHans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
parent 867e835f

drivers/media/video/ivtv/ivtv-ioctl.c

+2 −1
Original line number Diff line number Diff line
@@ -742,7 +742,8 @@ int ivtv_v4l2_ioctls(struct ivtv *itv, struct file *filp, unsigned int cmd, void 


		memset(vcap, 0, sizeof(*vcap));

		strcpy(vcap->driver, IVTV_DRIVER_NAME);     /* driver name */

		strcpy(vcap->card, itv->card_name); 	    /* card type */

		strncpy(vcap->card, itv->card_name,

				sizeof(vcap->card)-1); 	    /* card type */

		strcpy(vcap->bus_info, pci_name(itv->dev)); /* bus info... */

		vcap->version = IVTV_DRIVER_VERSION; 	    /* version */

		vcap->capabilities = itv->v4l2_cap; 	    /* capabilities */