Commit d24d7dbf authored Jul 18, 2012 by Jovi Zhang Committed by Steven Rostedt Jan 21, 2013

tracing: Verify target file before registering a uprobe event

Without this patch, we can register a uprobe event for a directory.
Enabling such a uprobe event would anyway fail.

Example:
$ echo 'p /bin:0x4245c0' > /sys/kernel/debug/tracing/uprobe_events

However dirctories cannot be valid targets for uprobe.
Hence verify if the target is a regular file during the probe
registration.

Link: http://lkml.kernel.org/r/20130103004212.690763002@goodmis.org



Cc: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Jovi Zhang <bookjovi@gmail.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
[ cleaned up whitespace and removed redundant IS_DIR() check ]
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

parent d8a0349c

kernel/trace/trace_uprobe.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -258,6 +258,10 @@ static int create_trace_uprobe(int argc, char **argv)
		goto fail_address_parse;

		inode = igrab(path.dentry->d_inode);
		if (!S_ISREG(inode->i_mode)) {
		ret = -EINVAL;
		goto fail_address_parse;
		}

		argc -= 2;
		argv += 2;
		@@ -356,7 +360,7 @@ static int create_trace_uprobe(int argc, char **argv)
		if (inode)
		iput(inode);

		pr_info("Failed to parse address.\n");
		pr_info("Failed to parse address or file.\n");

		return ret;
		}