Commit d1d85780 authored Sep 24, 2013 by Joe Perches Committed by Linus Torvalds Sep 24, 2013

checkpatch: make extern in .h prototypes quieter



The use of extern in .h files is a bit contentious.

Make the warning be emitted only when --strict is used on the command
line.

Signed-off-by: Joe Perches <joe@perches.com>
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 58f09e00

scripts/checkpatch.pl

+2 −2

Original line number	Diff line number	Diff line
		@@ -3975,7 +3975,7 @@ sub string_find_replace {
		# check for new externs in .h files.
		if ($realfile =~ /\.h$/ &&
		$line =~ /^\+\s(extern\s+)$Type\s$Ident\s*\(/s) {
		if (WARN("AVOID_EXTERNS",
		if (CHK("AVOID_EXTERNS",
		"extern prototypes should be avoided in .h files\n" . $herecurr) &&
		$fix) {
		$fixed[$linenr - 1] =~ s/(.)\bextern\b\s(.*)/$1$2/;