Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cfe4f275 authored by Guennadi Liakhovetski's avatar Guennadi Liakhovetski Committed by Dan Williams
Browse files

dmaengine: fix dmatest to verify minimum transfer length and test buffer size 



Transfers and the test buffer have to be at least align bytes long.

Signed-off-by: default avatarGuennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
parent ddb4f0f0

drivers/dma/dmatest.c

+12 −4
Original line number Diff line number Diff line
@@ -298,10 +298,6 @@ static int dmatest_func(void *data) 


		total_tests++;



		len = dmatest_random() % test_buf_size + 1;

		src_off = dmatest_random() % (test_buf_size - len + 1);

		dst_off = dmatest_random() % (test_buf_size - len + 1);



		/* honor alignment restrictions */

		if (thread->type == DMA_MEMCPY)

			align = dev->copy_align;
@@ -310,7 +306,19 @@ static int dmatest_func(void *data) 
		else if (thread->type == DMA_PQ)

			align = dev->pq_align;



		if (1 << align > test_buf_size) {

			pr_err("%u-byte buffer too small for %d-byte alignment\n",

			       test_buf_size, 1 << align);

			break;

		}



		len = dmatest_random() % test_buf_size + 1;

		len = (len >> align) << align;

		if (!len)

			len = 1 << align;

		src_off = dmatest_random() % (test_buf_size - len + 1);

		dst_off = dmatest_random() % (test_buf_size - len + 1);



		src_off = (src_off >> align) << align;

		dst_off = (dst_off >> align) << align;