Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cfa969e3 authored by David S. Miller's avatar David S. Miller
Browse files

Revert "ehea: Use the standard logging functions"



This reverts commit 539995d1.

As reported by Stephen Rothwell, this breaks the build.

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 40fe7d88
Loading
Loading
Loading
Loading
+13 −0
Original line number Diff line number Diff line
@@ -130,6 +130,19 @@

/* utility functions */

#define ehea_info(fmt, args...) \
	printk(KERN_INFO DRV_NAME ": " fmt "\n", ## args)

#define ehea_error(fmt, args...) \
	printk(KERN_ERR DRV_NAME ": Error in %s: " fmt "\n", __func__, ## args)

#ifdef DEBUG
#define ehea_debug(fmt, args...) \
	printk(KERN_DEBUG DRV_NAME ": " fmt, ## args)
#else
#define ehea_debug(fmt, args...) do {} while (0)
#endif

void ehea_dump(void *adr, int len, char *msg);

#define EHEA_BMASK(pos, length) (((pos) << 16) + (length))
+8 −10
Original line number Diff line number Diff line
@@ -26,8 +26,6 @@
 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 */

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

#include "ehea.h"
#include "ehea_phyp.h"

@@ -120,9 +118,9 @@ static int ehea_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
	ret = ehea_set_portspeed(port, sp);

	if (!ret)
		netdev_info(dev,
			    "Port speed successfully set: %dMbps %s Duplex\n",
			    port->port_speed,
		ehea_info("%s: Port speed successfully set: %dMbps "
			  "%s Duplex",
			  port->netdev->name, port->port_speed,
			  port->full_duplex == 1 ? "Full" : "Half");
out:
	return ret;
@@ -136,9 +134,9 @@ static int ehea_nway_reset(struct net_device *dev)
	ret = ehea_set_portspeed(port, EHEA_SPEED_AUTONEG);

	if (!ret)
		netdev_info(port->netdev,
			    "Port speed successfully set: %dMbps %s Duplex\n",
			    port->port_speed,
		ehea_info("%s: Port speed successfully set: %dMbps "
			  "%s Duplex",
			  port->netdev->name, port->port_speed,
			  port->full_duplex == 1 ? "Full" : "Half");
	return ret;
}