Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cf7505ef authored by Chuansheng Liu's avatar Chuansheng Liu Committed by Wolfram Sang
Browse files

i2c: nomadik: Fix the usage of wait_for_completion_timeout 



The return value of wait_for_completion_timeout() is always
>= 0 with unsigned int type.

So the condition "ret < 0" or "ret >= 0" is pointless.

Signed-off-by: default avatarliu chuansheng <chuansheng.liu@intel.com>
Signed-off-by: default avatarWolfram Sang <w.sang@pengutronix.de>
parent 77b67063

drivers/i2c/busses/i2c-nomadik.c

+0 −14
Original line number Diff line number Diff line
@@ -435,13 +435,6 @@ static int read_i2c(struct nmk_i2c_dev *dev, u16 flags) 
	timeout = wait_for_completion_timeout(

		&dev->xfer_complete, dev->adap.timeout);



	if (timeout < 0) {

		dev_err(&dev->adev->dev,

			"wait_for_completion_timeout "

			"returned %d waiting for event\n", timeout);

		status = timeout;

	}



	if (timeout == 0) {

		/* Controller timed out */

		dev_err(&dev->adev->dev, "read from slave 0x%x timed out\n",
@@ -523,13 +516,6 @@ static int write_i2c(struct nmk_i2c_dev *dev, u16 flags) 
	timeout = wait_for_completion_timeout(

		&dev->xfer_complete, dev->adap.timeout);



	if (timeout < 0) {

		dev_err(&dev->adev->dev,

			"wait_for_completion_timeout "

			"returned %d waiting for event\n", timeout);

		status = timeout;

	}



	if (timeout == 0) {

		/* Controller timed out */

		dev_err(&dev->adev->dev, "write to slave 0x%x timed out\n",