Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cf06cbb9 authored by Julia Lawall's avatar Julia Lawall Committed by Mark Brown
Browse files

regulator: ti-abb: simplify platform_get_resource_byname/devm_ioremap_resource 

Remove unneeded error handling on the result of a call to
platform_get_resource_byname when the value is passed to devm_ioremap_resource.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression pdev,res,e,e1;
expression ret != 0;
identifier l;
@@

  res = platform_get_resource_byname(...);
- if (res == NULL) { ... \(goto l;\|return ret;\) }
  e = devm_ioremap_resource(e1, res);
// </smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
parent b36f4be3

drivers/regulator/ti-abb-regulator.c

+0 −10
Original line number Diff line number Diff line
@@ -717,11 +717,6 @@ static int ti_abb_probe(struct platform_device *pdev) 
	/* Map ABB resources */

	pname = "base-address";

	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, pname);

	if (!res) {

		dev_err(dev, "Missing '%s' IO resource\n", pname);

		ret = -ENODEV;

		goto err;

	}

	abb->base = devm_ioremap_resource(dev, res);

	if (IS_ERR(abb->base)) {

		ret = PTR_ERR(abb->base);
@@ -770,11 +765,6 @@ static int ti_abb_probe(struct platform_device *pdev) 


	pname = "ldo-address";

	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, pname);

	if (!res) {

		dev_dbg(dev, "Missing '%s' IO resource\n", pname);

		ret = -ENODEV;

		goto skip_opt;

	}

	abb->ldo_base = devm_ioremap_resource(dev, res);

	if (IS_ERR(abb->ldo_base)) {

		ret = PTR_ERR(abb->ldo_base);