Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ceefaf5d authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

[media] tuner-i2c: be consistent with I2C declaration 



On alpha, gcc warns a log about signed/unsigned ballance, with
produces 3185 warnings. Ok, this is bogus, but it indicates that
the declaration at V4L2 side is not consistent with the one at
I2C.

With this trivial patch, the number of errors reduce to 2959
warnings. Still too much, but it is 7.1% less. So let's do it.

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent dd7a2acf

drivers/media/tuners/tuner-i2c.h

+6 −4
Original line number Diff line number Diff line
@@ -33,7 +33,8 @@ struct tuner_i2c_props { 
	char *name;

};



static inline int tuner_i2c_xfer_send(struct tuner_i2c_props *props, char *buf, int len)

static inline int tuner_i2c_xfer_send(struct tuner_i2c_props *props,

				      unsigned char *buf, int len)

{

	struct i2c_msg msg = { .addr = props->addr, .flags = 0,

			       .buf = buf, .len = len };
@@ -42,7 +43,8 @@ static inline int tuner_i2c_xfer_send(struct tuner_i2c_props *props, char *buf, 
	return (ret == 1) ? len : ret;

}



static inline int tuner_i2c_xfer_recv(struct tuner_i2c_props *props, char *buf, int len)

static inline int tuner_i2c_xfer_recv(struct tuner_i2c_props *props,

				      unsigned char *buf, int len)

{

	struct i2c_msg msg = { .addr = props->addr, .flags = I2C_M_RD,

			       .buf = buf, .len = len };
@@ -52,8 +54,8 @@ static inline int tuner_i2c_xfer_recv(struct tuner_i2c_props *props, char *buf, 
}



static inline int tuner_i2c_xfer_send_recv(struct tuner_i2c_props *props,

					   char *obuf, int olen,

					   char *ibuf, int ilen)

					   unsigned char *obuf, int olen,

					   unsigned char *ibuf, int ilen)

{

	struct i2c_msg msg[2] = { { .addr = props->addr, .flags = 0,

				    .buf = obuf, .len = olen },