Commit ceec6340 authored Jun 30, 2014 by Jiri Slaby Committed by Jiri Kosina Jun 30, 2014

HID: sensor-hub: fix potential memory leak



hsdev is not freed in sensor_hub_probe when kasprintf inside the for
loop fails. This is because hsdev is not set to platform_data yet (to
be freed by the code in the err_no_mem label). So free the memory
explicitly in the 'if' branch, as this is the only place where this is
(and will) be needed.

Reported-by: coverity
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: srinivas pandruvada <srinivas.pandruvada@intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent 66e54827

drivers/hid/hid-sensor-hub.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -636,6 +636,7 @@ static int sensor_hub_probe(struct hid_device *hdev,
		if (name == NULL) {
		hid_err(hdev, "Failed MFD device name\n");
		ret = -ENOMEM;
		kfree(hsdev);
		goto err_no_mem;
		}
		sd->hid_sensor_hub_client_devs[