Commit ccb36da1 authored Feb 28, 2015 by Vaishali Thakkar Committed by David S. Miller Mar 01, 2015

net: stmmac: Use setup_timer and mod_timer



Use timer API functions setup_timer and mod_timer instead
of structure assignments as they are standard way to set
the timer and to update the expire field of an active timer
respectively.

This is done using Coccinelle and semantic patch used for
this is as follows:

// <smpl>
@@
expression x,y,z,a,b;
@@

-init_timer (&x);
+setup_timer (&x, y, z);
+mod_timer (&a, b);
-x.function = y;
-x.data = z;
-x.expires = b;
-add_timer(&a);
// </smpl>

Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6753a971

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

+5 −5

Original line number	Diff line number	Diff line
		@@ -310,11 +310,11 @@ bool stmmac_eee_init(struct stmmac_priv *priv)
		spin_lock_irqsave(&priv->lock, flags);
		if (!priv->eee_active) {
		priv->eee_active = 1;
		init_timer(&priv->eee_ctrl_timer);
		priv->eee_ctrl_timer.function = stmmac_eee_ctrl_timer;
		priv->eee_ctrl_timer.data = (unsigned long)priv;
		priv->eee_ctrl_timer.expires = STMMAC_LPI_T(eee_timer);
		add_timer(&priv->eee_ctrl_timer);
		setup_timer(&priv->eee_ctrl_timer,
		stmmac_eee_ctrl_timer,
		(unsigned long)priv);
		mod_timer(&priv->eee_ctrl_timer,
		STMMAC_LPI_T(eee_timer));

		priv->hw->mac->set_eee_timer(priv->hw,
		STMMAC_DEFAULT_LIT_LS,