Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cc83f833 authored by Alberto Garcia's avatar Alberto Garcia Committed by Greg Kroah-Hartman
Browse files

ipack/devices/ipoctal: Fix race condition during Tx 



In order to transmit data, the driver enables Tx and sleeps until
*board_write is set to 1 by the interrupt handler.

It can happen, though, that the data is sent even before the process
is asleep. In this case *board_write must be set to 1 anyway,
otherwise we will be waiting for a condition that will never be true.

Signed-off-by: default avatarAlberto Garcia <agarcia@igalia.com>
Signed-off-by: default avatarSamuel Iglesias Gonsalvez <siglesias@igalia.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8e9a4a9a

drivers/ipack/devices/ipoctal.c

+4 −7
Original line number Diff line number Diff line
@@ -195,15 +195,12 @@ static void ipoctal_irq_tx(struct ipoctal_channel *channel) 
	*pointer_write = *pointer_write % PAGE_SIZE;

	channel->nb_bytes--;



	if ((channel->nb_bytes == 0) &&

	    (waitqueue_active(&channel->queue))) {



		if (channel->board_id != IPACK1_DEVICE_ID_SBS_OCTAL_485) {

	if (channel->nb_bytes == 0 &&

	    channel->board_id != IPACK1_DEVICE_ID_SBS_OCTAL_485) {

		*channel->board_write = 1;

		wake_up_interruptible(&channel->queue);

	}

}

}



static void ipoctal_irq_channel(struct ipoctal_channel *channel)

{