Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cc548166 authored by Dan Carpenter's avatar Dan Carpenter Committed by Joel Becker
Browse files

ocfs2/cluster: dereferencing before checking in nst_seq_show() 



In the original code, we dereferenced "nst" before checking that it was
non-NULL.  I moved the check forward and pulled the code in an indent
level.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarJoel Becker <joel.becker@oracle.com>
parent e70d8450

fs/ocfs2/cluster/netdebug.c

+24 −23
Original line number Diff line number Diff line
@@ -133,13 +133,14 @@ static int nst_seq_show(struct seq_file *seq, void *v) 


	spin_lock(&o2net_debug_lock);

	nst = next_nst(dummy_nst);

	if (!nst)

		goto out;



	now = ktime_get();

	sock = ktime_to_us(ktime_sub(now, nst->st_sock_time));

	send = ktime_to_us(ktime_sub(now, nst->st_send_time));

	status = ktime_to_us(ktime_sub(now, nst->st_status_time));



	if (nst != NULL) {

	/* get_task_comm isn't exported.  oh well. */

	seq_printf(seq, "%p:\n"

		   "  pid:          %lu\n"
@@ -161,8 +162,8 @@ static int nst_seq_show(struct seq_file *seq, void *v) 
		   (long long)sock,

		   (long long)send,

		   (long long)status);

	}



out:

	spin_unlock(&o2net_debug_lock);



	return 0;