Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cb1ca0b3 authored by Jassi Brar's avatar Jassi Brar
Browse files

mailbox: mailbox-test: avoid reading iomem twice 



Don't pass mmio region as source to print_hex_dump() and then
again to memcpy_fromio(). Do it once and give print_hex_dump()
the buffer we just read the data in.

Acked-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarJassi Brar <jaswinder.singh@linaro.org>
parent c3ac54a6

drivers/mailbox/mailbox-test.c

+2 −3
Original line number Diff line number Diff line
@@ -221,11 +221,10 @@ static void mbox_test_receive_message(struct mbox_client *client, void *message) 


	spin_lock_irqsave(&tdev->lock, flags);

	if (tdev->mmio) {

		memcpy_fromio(tdev->rx_buffer, tdev->mmio, MBOX_MAX_MSG_LEN);

		print_hex_dump(KERN_INFO, "Client: Received [MMIO]: ",

			       DUMP_PREFIX_ADDRESS, MBOX_BYTES_PER_LINE, 1,

			       __io_virt(tdev->mmio), MBOX_MAX_MSG_LEN, true);

		memcpy_fromio(tdev->rx_buffer, tdev->mmio, MBOX_MAX_MSG_LEN);



			       tdev->rx_buffer, MBOX_MAX_MSG_LEN, true);

	} else if (message) {

		print_hex_dump(KERN_INFO, "Client: Received [API]: ",

			       DUMP_PREFIX_ADDRESS, MBOX_BYTES_PER_LINE, 1,