Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ca25d6b0 authored by Daniel Vetter's avatar Daniel Vetter
Browse files

drm/nouveau: Drop dev->struct_mutex from fbdev init 



Doesn't protect anything at all.

With this patch nouveau is completely dev->struct_mutex free!

Cc: Ben Skeggs <bskeggs@redhat.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1459330852-27668-6-git-send-email-daniel.vetter@ffwll.ch
parent 068149ad

drivers/gpu/drm/nouveau/nouveau_fbcon.c

+0 −5
Original line number Diff line number Diff line
@@ -386,8 +386,6 @@ nouveau_fbcon_create(struct drm_fb_helper *helper, 
		}

	}



	mutex_lock(&dev->struct_mutex);



	info = drm_fb_helper_alloc_fbi(helper);

	if (IS_ERR(info)) {

		ret = PTR_ERR(info);
@@ -426,8 +424,6 @@ nouveau_fbcon_create(struct drm_fb_helper *helper, 


	/* Use default scratch pixmap (info->pixmap.flags = FB_PIXMAP_SYSTEM) */



	mutex_unlock(&dev->struct_mutex);



	if (chan)

		nouveau_fbcon_accel_init(dev);

	nouveau_fbcon_zfill(dev, fbcon);
@@ -441,7 +437,6 @@ nouveau_fbcon_create(struct drm_fb_helper *helper, 
	return 0;



out_unlock:

	mutex_unlock(&dev->struct_mutex);

	if (chan)

		nouveau_bo_vma_del(nvbo, &fbcon->nouveau_fb.vma);

	nouveau_bo_unmap(nvbo);